Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually add the CI workflow #153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

binford2k
Copy link
Contributor

  • Add CloudCI publish and PR testing workflows
  • whoops, forgot to add the CI workflow

@binford2k binford2k requested review from kajinamit and a team as code owners January 10, 2024 00:49
nmburgan
nmburgan previously approved these changes Jan 10, 2024
Copy link
Contributor

@nmburgan nmburgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you make checks no angy

@kajinamit kajinamit mentioned this pull request Jan 10, 2024
@kajinamit
Copy link
Collaborator

Thanks ! I've submitted a PR to address the errors ( #154 ). Do you mind pulling the change (or merge the PR) ?

@binford2k
Copy link
Contributor Author

well the errors have all been fixed. I don't have time or domain expertise to fix all the warnings.

@kajinamit
Copy link
Collaborator

It seems most of the warnings are about missing descriptions. I'll try to take time to address these.

I'm wondering if we can tweak the job setting to skip warnings now . (so that we can merge this PR before all warnings are fixed)

@ekohl
Copy link
Contributor

ekohl commented Jan 11, 2024

I took a quick look at one file (#156) but I don't have the time to finish it now.

It would make sense to me to disable parameter_types and parameter_documentation for now.

@kajinamit
Copy link
Collaborator

I've created PR to add data types and parameter descriptions. #157

@kajinamit
Copy link
Collaborator

@binford2k Could you please check [1] and rebase this on that one when you get time ? I'm hoping to get this merged (and also create a new release)

[1] #157

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants