Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) - Pin yard to < 0.9.37 #401

Merged
merged 1 commit into from
Sep 5, 2024
Merged

(bug) - Pin yard to < 0.9.37 #401

merged 1 commit into from
Sep 5, 2024

Conversation

jordanbreen28
Copy link
Contributor

Summary

Yard 0.9.37 was released, which broke our pipeline and also broke some module CI.

This commit adds a temporary pin to the gem to < 0.9.37, until we can resolve these issues.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Yard 0.9.37 was released, which broke our pipeline and also broke some
module CI.

This commit adds a temporary pin to the gem to < 0.9.37, until we can
resolve these issues.
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (dadc21f) to head (88169c7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   70.88%   70.88%           
=======================================
  Files          78       78           
  Lines        2483     2483           
=======================================
  Hits         1760     1760           
  Misses        723      723           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@CoMfUcIoS CoMfUcIoS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 102e70c into main Sep 5, 2024
12 checks passed
@LukasAud LukasAud deleted the bug-pin_yard branch September 5, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants