Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "(maint) Exclude breaking rubocop versions" #397

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

gavindidrichsen
Copy link
Contributor

Reverts #393

Signed-off-by: Gavin Didrichsen <[email protected]>
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (2c26cb4) to head (ca1498e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   70.91%   70.88%   -0.04%     
==========================================
  Files          78       78              
  Lines        2486     2483       -3     
==========================================
- Hits         1763     1760       -3     
  Misses        723      723              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavindidrichsen gavindidrichsen marked this pull request as ready for review June 20, 2024 13:00
@gavindidrichsen gavindidrichsen requested review from bastelfreak and a team as code owners June 20, 2024 13:00
@gavindidrichsen
Copy link
Contributor Author

As I didn't add any functionality here but only correct syntax on existing code, I'm recommending we

Signed-off-by: Gavin Didrichsen <[email protected]>
@gavindidrichsen gavindidrichsen force-pushed the revert-393-maint_exclude_rubocop_versions branch from 60fa51d to ca1498e Compare June 20, 2024 13:08
@david22swan david22swan merged commit cbd6f81 into main Jun 20, 2024
11 of 12 checks passed
@david22swan david22swan deleted the revert-393-maint_exclude_rubocop_versions branch June 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants