Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) - fix rubocop #360

Merged
merged 1 commit into from
Jul 27, 2023
Merged

(maint) - fix rubocop #360

merged 1 commit into from
Jul 27, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner July 27, 2023 08:48
@GSPatton GSPatton merged commit e4525f7 into main Jul 27, 2023
11 checks passed
@GSPatton GSPatton deleted the maint-fix_rubocop branch July 27, 2023 09:36
@donoghuc
Copy link
Member

donoghuc commented Dec 4, 2023

@jordanbreen28 @GSPatton I do not believe this is strictly a ruby 2.7 compatible feature. This gem claims support for ruby 2.7 and delegation (...) is not supported with leading arguments in for example ruby 2.7.0 https://scriptday.com/blog/2020/09/12/ruby-3-0-added-leading-arguments-forwarding I think we need to revert this in order to maintain ruby 2.7 compatibility (i would expect breaking ruby compatability to be a major version bump in semver).

@donoghuc donoghuc mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSPatton GSPatton GSPatton approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanbreen28 @donoghuc @GSPatton