Allow to specify the type of remote authentication #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
5437_remote_auth_spec
branch
4 times, most recently
from
1200841
to
d29d56e
Compare
lubosmj
reviewed
Jun 6, 2024
mdellweg
force-pushed
the
5437_remote_auth_spec
branch
3 times, most recently
from
5cd00a0
to
1f3b4df
Compare
mdellweg
force-pushed
the
5437_remote_auth_spec
branch
from
f3025d2
to
2e03ece
Compare
When configuring remote authentication (by the reverse proxy), one should be able to augment the openAPI security specification accordingly. fixes pulp#5437
mdellweg
force-pushed
the
5437_remote_auth_spec
branch
from
2e03ece
to
d2fe1e9
Compare
ggainey
reviewed
Jun 10, 2024
| @@ -15,7 +15,7 @@ djangorestframework>=3.14.0,<=3.15.1 | |||
| djangorestframework-queryfields>=1.0,<=1.1.0 | |||
| drf-access-policy>=1.1.2,<1.5.1 | |||
| drf-nested-routers>=0.93.4,<=0.94.1 | |||
| drf-spectacular==0.26.5 # We monkeypatch this so we need a very narrow requirement string | |||
| drf-spectacular==0.27.2 # We monkeypatch this so we need a very narrow requirement string | |||
There was a problem hiding this comment.
Does this PR need 0.26.5 specifically? or is this an incidental change? If the latter - including in this PR makes the PR way harder to backport.
There was a problem hiding this comment.
It's worse than that. Seems like we need openapi 3.1 instead of 3.0.3 and now we need to coordinate a lot of other things including the openapi-generator.
But on the one hand we'll probably not backport this feature, and otoh i split this version bump into another PR already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring remote authentication (by the reverse proxy), one should be able to augment the openapi security specification accordingly.
fixes #5437