Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More instructions for use are added #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lgaticaq
Copy link

Add instructions for integrate in npm scripts and git hooks with lint-staged

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          51       51           
  Lines         942      942           
=======================================
  Hits          941      941           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42970c...1855a85. Read the comment docs.

README.md Outdated
```json
{
"scripts": {
"lint:pug": "glob-exec \"./src/**/*.pug\" -- \"pug-lint {{files.join(' ')}}\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the extra dependency glob-exec really needed? Could you achieve the same, but simpler, with standard xargs?

Even better, just pug-lint $(git ls-files '*.pug')?

More generally, I'm not sure such instructions add real value to the README: they're really generic.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggestion. I change script to git ls-files 'src/**/*.pug' | xargs pug-lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants