Fix filter bug and add tool to import translations from another catkeys file #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If humdinger says it's ok, I'll go with that :P Code looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Puckipedia, I hope you will consider adding this feature. This should make it much easier to update catkey files that you already have other translations for. The way I used this is I created a new en.catkeys file after making changes to translations in my app. Then I copied en.catkeys to de.catkeys to create a new german catalog, opened it in my modified CatKeysEditor and imported the previous de.catkeys file which had most of the translations I needed. Now all I need to do is add new translations for new text, or manually alter existing translation that didn't get imported because of some slight changes.
I match both the source and context for each translation unit when importing.
Also included is a fix for my #20 issue report. @humdingerb you may also be interested in this tool which should accomplish in maybe a different way what you posted in issue #17.