Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected identation of modules #663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keshav234156
Copy link
Member

The problem arose post #636
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Dec 1, 2020

@keshav234156
Copy link
Member Author

Screenshot from 2020-12-02 01-25-49
Screenshot from 2020-12-02 01-25-45
Screenshot from 2020-12-02 01-25-04
Screenshot from 2020-12-02 01-24-54

The problem was with module 1 and module 5

@keshav234156 keshav234156 reopened this Dec 1, 2020
@gitpod-io
Copy link

gitpod-io bot commented Dec 1, 2020

@jywarren
Copy link
Member

jywarren commented Dec 1, 2020

This looks great. I also noticed the toolbar in the rich text module is not consistent...

@jywarren
Copy link
Member

jywarren commented Dec 1, 2020

could it be somewhere around here?

$(".wk-switchboard button").addClass("btn-sm");

image

we don't have to solve this here. but just thinking it might be easy to add.

@keshav234156
Copy link
Member Author

keshav234156 commented Dec 1, 2020

could it be somewhere around here?

$(".wk-switchboard button").addClass("btn-sm");

image

we don't have to solve this here. but just thinking it might be easy to add.

@jywarren yes, I noticed that. I thought it would be better if we make a separate PR..

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Ready to merge then? Thanks @keshav234156 !!!

@keshav234156
Copy link
Member Author

@jywarren Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants