Strip even more redundant for parentheses #3243
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What remains is removing unnecessary brackets because yes, you can do
this:
for [x, y] in points:
print("this is valid code!!!")
I'm leaving this as a future task because it turns out simply
converting these square brackets into parentheses is not an AST-safe
transformation. And`maybe_make_parens_invisible_in_atom` is currently
not designed to handle square brackets and initial attemps to add a
boolean `treat_square_brackets_as_parens` parameter were unsuccessful.
ichard26
added
the
F: parentheses
ichard26
commented
Aug 29, 2022
| ) in points: | ||
| pass | ||
|
|
||
| for one_super_long_name_as_the_for_target_list_because_why_not_you_dont_control_me_i_have_total_freedom in (points): |
There was a problem hiding this comment.
The odd parentheses is a pre-existing bug in main. Something in right_hand_split or something similar is deciding to make the invisible parentheses around points visible even though the split failed. I'm happy to try to fix this before merging, but I probably won't get to it until September.
|
diff-shades is timing out, it could be simply GHA flakiness, but there could be a genuine infinite loop (or massive slowdown) somewhere. Since I'm in no rush to land this I'll mark this as draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3080.
What remains is removing unnecessary brackets because yes, you can do this:
I'm leaving this as a future task because it turns out simply converting these square brackets into parentheses is not an AST-safe transformation so letting the pre-existing logic handle the rest doesn't work. And
maybe_make_parens_invisible_in_atomis currently not designed to handle square brackets and initial attempts to add a booleantreat_square_brackets_as_parensparameter were unsuccessful.Checklist - did you ...