Exit with a correct exit code when outputting to the console #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the
scan
command and outputting the result to console would always exit with an exit code of1
regardless of whether there were any errors found or not.This messes up CI builds and other usages where the exit code is meaningful.
The bug was caused by invalid assumption in the result value of
Output\Console::render
: the$fail
variable is an integer, not an array.The following illustrates the previous situation and how using
count
always resulted in the exit code of1
.This patch fixes the bug;
Output\Console::render
now treats the$fail
variable as an integer and returns a correct exit status.