Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics path not using command-line argument value #904

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Fix metrics path not using command-line argument value #904

merged 1 commit into from
Jul 1, 2023

Conversation

hhromic
Copy link
Contributor

@hhromic hhromic commented Jul 1, 2023

Hello,
I casually discovered this bug while looking at the source code of the SNMP exporter.
The exporter currently hard codes /metrics instead of using the --web.telemetry-path command-line argument value.

The fix here aligns with the current approach in the Node Exporter:
https://github.com/prometheus/node_exporter/blob/c31ebb43590cb0055acd4bc00a432f6a2dafdd08/node_exporter.go#L188

SuperQ
SuperQ approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good find. I must have missed that when I was adjusting the landing page code.

@SuperQ SuperQ merged commit 30da795 into prometheus:main Jul 1, 2023
2 checks passed
@hhromic
Copy link
Contributor Author

hhromic commented Jul 1, 2023

Happy to help! :)

@hhromic hhromic deleted the fix-metrics-path branch July 1, 2023 15:38
SuperQ added a commit that referenced this pull request Jul 4, 2023
@SuperQ
Release 0.23.0-rc.0
93b4b21 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Jul 4, 2023
Merged
SuperQ added a commit that referenced this pull request Jul 5, 2023
@SuperQ
Release 0.23.0-rc.0
1ff92dd 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [ENHANCEMENT] Improved Lookup process for label information #908
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Jul 6, 2023
@SuperQ
Release 0.23.0-rc.0
671291e 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [ENHANCEMENT] Improved Lookup process for label information #908
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
RichiH pushed a commit that referenced this pull request Jul 6, 2023
@SuperQ
Release 0.23.0-rc.0 (#906)
4287732 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [ENHANCEMENT] Improved Lookup process for label information #908
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Jul 19, 2023
@SuperQ
Release v0.23.0-rc.1
b8467d2 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [FEATURE] Improved Lookup process for label information #908
* [ENHANCEMENT] Add support for parsing SNMP transport from target #914
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Jul 19, 2023
Merged
SuperQ added a commit that referenced this pull request Jul 19, 2023
@SuperQ
Release v0.23.0-rc.1
1523970 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [FEATURE] Improved Lookup process for label information #908
* [ENHANCEMENT] Add support for parsing SNMP transport from target #914
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Jul 19, 2023
@SuperQ
Release v0.23.0-rc.1
a20206f 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [FEATURE] Add support for parsing SNMP transport from target #914
* [ENHANCEMENT] Improved Lookup process for label information #908
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Jul 20, 2023
@SuperQ
Release v0.23.0-rc.1
f8be956 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [FEATURE] Add support for parsing SNMP transport from target #914
* [ENHANCEMENT] Improved Lookup process for label information #908
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Jul 20, 2023
@SuperQ
Release v0.23.0-rc.1 (#924)
982a1b3 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [FEATURE] Add support for parsing SNMP transport from target #914
* [ENHANCEMENT] Improved Lookup process for label information #908
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
SuperQ added a commit that referenced this pull request Aug 9, 2023
@SuperQ
Release v0.23.0
de5b9fa 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [FEATURE] Add support for parsing SNMP transport from target #914
* [ENHANCEMENT] Improved Lookup process for label information #908
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Aug 9, 2023
Merged
SuperQ added a commit that referenced this pull request Aug 16, 2023
@SuperQ
Release v0.23.0 (#940)
20657d2 
* Release v0.23.0

BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules #859
* [FEATURE] Add support for parsing SNMP transport from target #914
* [ENHANCEMENT] Improved Lookup process for label information #908
* [BUGFIX] Fix metrics path not using command-line argument value #904

Signed-off-by: SuperQ <[email protected]>

* Lint dashboards

Update dashboards to latest mixin linting.

Signed-off-by: SuperQ <[email protected]>

---------

Signed-off-by: SuperQ <[email protected]>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@hhromic
Fix metrics path not using command-line argument value (prometheus#904)
269286e 
Signed-off-by: Hugo Hromic <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@SuperQ
Release 0.23.0-rc.0 (prometheus#906)
cde39c5 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules prometheus#859
* [ENHANCEMENT] Improved Lookup process for label information prometheus#908
* [BUGFIX] Fix metrics path not using command-line argument value prometheus#904

Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@SuperQ
Release v0.23.0-rc.1 (prometheus#924)
1faaff6 
BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules prometheus#859
* [FEATURE] Add support for parsing SNMP transport from target prometheus#914
* [ENHANCEMENT] Improved Lookup process for label information prometheus#908
* [BUGFIX] Fix metrics path not using command-line argument value prometheus#904

Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
@SuperQ
Release v0.23.0 (prometheus#940)
789ab4f 
* Release v0.23.0

BREAKING CHANGES:

This version of the exporter introduces a new configuration file format. This
new format separates the walk and metric mappings from the connection and
authentication settings. This allows for easier configuration of different
auth params without having to duplicate the full walk and metric mapping.

See auth-split-migration.md for more details.

* [CHANGE] Split config of auth and modules prometheus#859
* [FEATURE] Add support for parsing SNMP transport from target prometheus#914
* [ENHANCEMENT] Improved Lookup process for label information prometheus#908
* [BUGFIX] Fix metrics path not using command-line argument value prometheus#904

Signed-off-by: SuperQ <[email protected]>

* Lint dashboards

Update dashboards to latest mixin linting.

Signed-off-by: SuperQ <[email protected]>

---------

Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhromic @SuperQ