Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverity: fix coverity issue report in crashlog #29

Merged

Conversation

bhe4
Copy link

@bhe4 bhe4 commented Sep 23, 2024

Tracked-On: OAM-122345

@sysopenci
Copy link

Improper Commit Message
Valid Commit Message
Improper Jira Status,
jira status not in ['In Progress','Implemented']

Copy link

@tanujtekriwal tanujtekriwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "Tests Done: " in commit message as part of maintaining commit message format.

Copy link

@tanujtekriwal tanujtekriwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. fix the resource leak in check_aplogs_tobackup
2. fix the Memory - corruptions in add_section
3. fix Uninitialized variables in enable_watchdog
4. fix the resource leak in find_system_last_kmsg
5. fix the Uninitialized variables in do_last_kmsg_copy

Tests Done:
1. Build and boot
2. crashlog function works

Tracked-On: OAM-126073
Signed-off-by: Bo He <[email protected]>
@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Oct 8, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Oct 8, 2024
Copy link

@tanujtekriwal tanujtekriwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 5e70bea into projectceladon:celadon/u/mr0/master Oct 9, 2024
17 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants