Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Document requirements for pre-launched VM #8703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daichifukui
Copy link

Hi all,

For a pre-launched VM, it is essential to include 'reboot=acpi' in the 'bootargs' of the scenario.xml file. Additionally, if the VM is named VM0, the grub.cfg file must contain
'module2 /boot/ACPI_VM0.bin ACPI_VM0'.

Currently, several scenario files located in misc/config_tools/data already support 'reboot=acpi'. Furthermore, the postinst Debian script automatically adds the 'module2' command to grub.cfg if the scenario is 'partitioned'. Therefore, by using the provided scenarios, the pre-launched VM can be used without any additional configuration.

However, when using a custom scenario file, there is a risk of omitting the necessary parameter and command for a pre-launched VM. To avoid such errors, it is useful to document these requirements.

Hence this pull request.
I'd appreciate it if you could review this request and merge it with the upstream.

@yuhuanX
Copy link

yuhuanX commented Aug 19, 2024

Can one of the admins verify this patch?

For a pre-launched VM, it is essential to include 'reboot=acpi' in
the 'bootargs' of the scenario.xml file. Additionally, if the VM
is named VM0, the grub.cfg file must contain
'module2 /boot/ACPI_VM0.bin ACPI_VM0'.

Currently, several scenario files located in misc/config_tools/data
already support 'reboot=acpi'. Furthermore, the postinst Debian
script automatically adds the 'module2' command to grub.cfg if the
scenario is 'partitioned'. Therefore, by using the provided
scenarios, the pre-launched VM can be used without any additional
configuration.

However, when using a custom scenario file, there is a risk of
omitting the necessary parameter and command for a pre-launched VM.
To avoid such errors, it is useful to document these requirements.

Signed-off-by: Daichi Fukui <[email protected]>
@yuhuanX
Copy link

yuhuanX commented Aug 20, 2024

start to build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants