Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests for Forest Quota Management Plugin Library #509

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

atantawi
Copy link
Collaborator

Add/update unit tests issue #319

Added/updated unit tests for:
Package quota: Allocation, QuotaNode
Package tree: Tree, Node

(more units needed and in progress)

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anishasthana for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metalcycling
Copy link
Collaborator

metalcycling commented Jul 25, 2023

Wow, this is new. I've never seen this stuff like the openshift-ci message or the extra checks. I made a PR yesterday and it didn't have any of this. @asm582 Have you seen this?

@metalcycling
Copy link
Collaborator

@atantawi any chance we can move this forward?

@atantawi atantawi force-pushed the testing branch 2 times, most recently from f4b5ffd to 9f82346 Compare August 21, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants