Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low contrast between background and foreground colors (text) #441

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shahnoor-khan
Copy link

worked on issue #427 .
changed the color contrast between background and hover color in footer, so the people with color blindness can also read clearly.
Before the hover color of anchor tag used to be like this:
image
to this:
Screenshot_20230213_062854

Changes made on footer:
Screenshot_20230212_084104
to this:
Screenshot_20230212_083818
I'm new to open source contributions. Can I work further on this issue #427 to improve the website?
Any advice will be appreciated :)

@SableRaf SableRaf requested a review from runemadsen February 13, 2023 13:21
@SableRaf
Copy link
Collaborator

Thanks for your contribution @shahnoor-khan! ⭐️ Tagging @runemadsen for review

@SableRaf
Copy link
Collaborator

Hi @shahnoor-khan,

Thanks for your work on issue #427. A couple of things before we can merge the PR:

  1. Could we change the yellow in the footer to a light blue that's already used in the site's design?
  2. While the on-click text color for cards is improved, the default grey could still use more contrast against the white.

Thanks for your help on this!

Raphaël

@shahnoor-khan
Copy link
Author

Hey @SableRaf
Thanks for reviewing changes.

  1. Yes, we could do that and I actually tried yellow because light and dark were getting mixed with each other but I could change that again.
  2. Ok, I'll go with darker gray there.

@SableRaf
Copy link
Collaborator

@Stefterv Thanks for reviewing this but I think you may have missed the changes I requested in my May 30, 2023 reply :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants