added loadFilterShader function #7445
Open
+66
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepagurek
reviewed
Dec 23, 2024
davepagurek
reviewed
Dec 24, 2024
| * @param {Function} [failureCallback] callback to be called if there is an error | ||
| * loading the shader. Will be passed the | ||
| * error event. | ||
| * @return {Promise<p5.Shader>} a promise that resolves with a shader object |
There was a problem hiding this comment.
This looks good @Rishab87 !
@limzykenneth we probably need to update the docs for other load* methods to indicate they return promises now if we haven't already, and likely we will need to update the FES code to handle templated Promise types
Co-authored-by: Dave Pagurek <[email protected]>
|
fixed the formatting |
|
@davepagurek do tell if anything else needs to be done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6852
Changes:
I have added loadFilterShader function to keep things consistent as mentioned in the issue.
Screenshots of the change:
PR Checklist
npm run lintpasses