Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update!: Add Grayjay to frontends #2720

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

I-I-IT
Copy link
Contributor

@I-I-IT I-I-IT commented Aug 20, 2024

Changes proposed in this PR:

Add Grayjay. It has proved to be a reliable way to watch Youtube videos, but it is much more than that.

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

@I-I-IT
Copy link
Contributor Author

I-I-IT commented Aug 20, 2024

The grayjay icon : https://grayjay.app/images/Vectors-Wrapper_7.svg

Grayjay

@jonaharagon jonaharagon changed the title Add Grayjay to frontends update!: Add Grayjay to frontends Aug 20, 2024
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/grayjay-frontend/14616/44

@ph00lt0
Copy link
Member

ph00lt0 commented Aug 21, 2024

@redoomed1 redoomed1 added the c:software self-hosted/decentralized software and related topics label Aug 21, 2024
@I-I-IT
Copy link
Contributor Author

I-I-IT commented Aug 21, 2024

@I-I-IT please see https://github.com/privacyguides/privacyguides.org/actions/runs/10486072648/job/29043519580?pr=2720

I saw the build failed, but I dont understand why.

Oh, I see. Is this something on my end. I will look into it later.

-----------+

Request POST /repos//issues/2720/comments failed with 403: Forbidden
Request POST /repos//issues/2720/comments failed with 403: Forbidden
[GitHub Comment Reporter] Unable to post pull request comment: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/issues/comments#create-an-issue-comment", "status": "403"}.
To enable this function, please add permissions in your Github Actions Workflow:
permissions:
issues: write
pull-requests: write

@redoomed1
Copy link
Member

redoomed1 commented Aug 21, 2024

I saw the build failed, but I dont understand why.

Well, if you're adding a new tool to any tool page, an entry should be added to the appropriate section in tools.md as well.

Also, the svg canvas size should be 128x128, per the contributor guidelines.

Copy link
Member

@redoomed1 redoomed1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the conclusion reached in the recent discussion on the definition of open source, the criteria for frontends must also be changed if this tool is going to be added to this page.

I-I-IT added 3 commits August 23, 2024 12:58
Signed-off-by: Triple T <[email protected]>
empty


Signed-off-by: Triple T <[email protected]>
Copy link

Your preview is ready!

Name Link
🔨 Latest commit 11a9f82
😎 Preview https://2720--glowing-salamander-8d7127.netlify.app/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does grayjay have an alt logo which works on a light background?

Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can't be merged unless we want to change the criteria to say something like "recommended frontends must have their source code be publicly available" (as opposed to the current "open source" requirement that we determined does not apply to Grayjay on the forum)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics
Projects
Status: Needs Changes
Development

Successfully merging this pull request may close these issues.

6 participants