Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTB House: Resolve AUCTION_PRICE macro #3901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

piotrj-rtbh
Copy link
Contributor

@piotrj-rtbh piotrj-rtbh commented Sep 4, 2024

Type of change

  • Feature

Description of change

The adapter is now able to resolve OpenRTB macro: ${AUCTION_PRICE}
PBS-Java counterpart PR: prebid/prebid-server-java#3421

Other information

Please reach us at [email protected] with [email protected] and cc [email protected].

Copy link

github-actions bot commented Sep 4, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 90bdced

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:29:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:37:	MakeRequests		94.1%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:108:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:130:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:197:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:208:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:228:	resolveMacros		100.0%
total:									(statements)		97.8%

@bsardo bsardo changed the title RTB House: resolve oRTB AUCTION_PRICE macro RTB House: Resolve ORTB AUCTION_PRICE macro Sep 26, 2024
@bsardo bsardo changed the title RTB House: Resolve ORTB AUCTION_PRICE macro RTB House: Resolve AUCTION_PRICE macro Sep 26, 2024
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cafe00d

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:29:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:37:	MakeRequests		94.1%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:108:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:130:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:197:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:208:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:228:	resolveMacros		100.0%
total:									(statements)		97.8%

@bsardo bsardo self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants