Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "freestyle" in multiplayer #31260

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Dec 24, 2024

Prereqs:

Old Server New Server
Old Client 🟢 🔴
New Client 🔴 🟢

Preamble

I was told to effectively hack this in, and was not given an opportunity to refactor multiplayer to properly support it or even to be able to write tests without pulling my hair out. So here goes.

Have I done some basic testing to see things work? Yes.
Will things break? Definitely.
Do I know what will break? Nope.

Description

2024-12-24.19-46-05.mp4

I've named this "freestyle", because I see a future where this is more than just beatmap/ruleset but also mods and thus include "freemods" in it. Perhaps something like a menu where you can choose what is free.

For the time being, when it's enabled, it will disable mods/freemods. I'm not sure what the intended UX is, but it will definitely be a lot more complicated due to mod types not matching between rulesets, i.e. this will fail a ton of validation everywhere. So I'm keeping it simple.

There's no display in the room for what/how other users have chosen to play, I'm not even sure where I'd add that in because the room design is a whole bunch of mess. There's already no display of other users' freemods either, so /shrug?

@peppy
Copy link
Member

peppy commented Dec 24, 2024

There's already no display of other users' freemods either, so /shrug?

2024-12-24 21 08 35@2x

It's shown here. I think adding the ruleset icon in the same flow area at minimum would be good to have.

@peppy
Copy link
Member

peppy commented Dec 24, 2024

@ppy/team-design able to provide some basic design direction for how ruleset and difficulty selection could be shown per-user here?

@smoogipoo
Copy link
Contributor Author

Had to pretty much rewrite the entire screen and add server-side support to do the above ¯\(ツ)/¯. Added it as a ruleset icon displayed on the panel:

2024-12-25.23-36-05.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants