-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale down beatmap cards #30748
base: master
Are you sure you want to change the base?
Scale down beatmap cards #30748
Conversation
At this point I question these local scale overrides. "Just" change the metrics of the cards to reflect this everywhere? |
Have you checked the remaining usage of this in a list view ( |
Fair enough, I'll scale the card itself |
I didn't scale beatmap badges as they've seem to be correctly sized for the smaller card already, and didn't change the nano-sized cards at all since they seem to be fine too |
Keep in mind when reviewing this that some usages are now smaller than they used to be (one example is the solo spectator screen). |
I intentionally didn't scale any of the usages up to the previous size to make it consistent across all card usages and it didn't look wrong to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I've said, I didn't change badges because they looked too small for the original size already, as for the other differences I think that's probably because I didn't scale elements exactly 0.8x, but to the closest integer size (so things that were 12 became 10 instead of 9.6 and such) |
I can agree that the larger badges look better. Previously they look too small. |
As long as you also accept the tradeoff that less of artist/title may become visible as a result... |
Resolves #30649
Before-after:
Extra:
Normal: