Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add P-R lettered article stubs from glossary #3867

Merged
merged 20 commits into from
Dec 9, 2020
Merged

Conversation

Pennek
Copy link
Contributor

@Pennek Pennek commented Jul 11, 2020

Part of organization effort - #3143
Probably the heaviest commit I've made to date. I split up the old performance points article into multiple new ones. Some of them are stubs and some of them are fully fleshed out articles. Gosh I want those hours spent back...

Adds:

  • Rank
  • Pass
  • peppy
  • Performance Points
  • Performance Point System
  • ppv2
  • Total Performance Points
  • Weighting System
  • Recalculate Slider Lengths
  • Resnap
  • Ranking
  • Restricted Mode

Modifies:

  • Disambiguation
  • ppv1 (added needs_cleanup tag)

and outdates a couple of translations

@Pennek Pennek mentioned this pull request Jul 11, 2020
24 tasks
Copy link
Contributor

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the pp article??

wiki/Disambiguation/Rank/en.md Outdated Show resolved Hide resolved
wiki/Disambiguation/Rank/en.md Outdated Show resolved Hide resolved
wiki/Pass/en.md Outdated Show resolved Hide resolved
wiki/People/peppy/en.md Outdated Show resolved Hide resolved
wiki/Performance_Points/Performance_Point_Systems/en.md Outdated Show resolved Hide resolved
wiki/Recalculate_Slider_Lengths/en.md Outdated Show resolved Hide resolved
wiki/Resnap/en.md Outdated Show resolved Hide resolved
wiki/Resnap/en.md Outdated Show resolved Hide resolved
wiki/Restricted_Mode/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
@MegaApplePi MegaApplePi removed the state/blocked don't merge label Sep 12, 2020
MegaApplePi
MegaApplePi previously approved these changes Nov 19, 2020
@MegaApplePi MegaApplePi requested review from cl8n, Joehuu and TPGPL November 19, 2020 05:17
Joehuu
Joehuu previously requested changes Nov 19, 2020
wiki/Resnap/en.md Outdated Show resolved Hide resolved
wiki/Disambiguation/Rank/en.md Outdated Show resolved Hide resolved
wiki/Pass/en.md Outdated Show resolved Hide resolved
wiki/People/peppy/en.md Outdated Show resolved Hide resolved
wiki/Performance_points/Total_performance_points/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
wiki/Recalculate_slider_lengths/en.md Outdated Show resolved Hide resolved
wiki/Restricted_mode/en.md Outdated Show resolved Hide resolved
MegaApplePi and others added 2 commits November 19, 2020 18:04
Some files were collapsed so I missed those ones.

Co-authored-by: Joseph Madamba <[email protected]>
TPGPL
TPGPL previously requested changes Nov 27, 2020
wiki/Disambiguation/Rank/en.md Outdated Show resolved Hide resolved
wiki/Disambiguation/Rank/en.md Outdated Show resolved Hide resolved
wiki/Pass/en.md Outdated Show resolved Hide resolved
wiki/Pass/en.md Outdated Show resolved Hide resolved
wiki/People/peppy/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
wiki/Ranking/en.md Outdated Show resolved Hide resolved
@TicClick
Copy link
Contributor

TicClick commented Dec 8, 2020

what's the current status of this? what input does it need, apart from fixing linting errors? @Pennek and the reviewers

@Pennek
Copy link
Contributor Author

Pennek commented Dec 8, 2020

Sorry, ive abandoned this PR. Hope TPGL and Map have an overview

@TicClick TicClick requested review from MegaApplePi and TPGPL December 8, 2020 18:05
@MegaApplePi
Copy link
Contributor

@TicClick I was waiting for an explicit approval from another wikifriend since I began making more changes from the comments/suggestions. Though, I think this pull request should be good enough now since there were at least some more suggestions after a long period of time. I'll go ahead and merge it now.

MegaApplePi
MegaApplePi previously approved these changes Dec 9, 2020
@MegaApplePi MegaApplePi dismissed stale reviews from Joehuu and TPGPL December 9, 2020 00:22

Suggestions were applied.

@MegaApplePi MegaApplePi merged commit a7cb2b8 into ppy:master Dec 9, 2020
@Pennek Pennek deleted the glossary-p branch December 9, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants