-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support markdown input and preview in beatmap discussions #9991
Draft
notbakaneko
wants to merge
43
commits into
ppy:master
Choose a base branch
from
notbakaneko:feature/discussion-post-markdown-preview
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support markdown input and preview in beatmap discussions #9991
notbakaneko
wants to merge
43
commits into
ppy:master
from
notbakaneko:feature/discussion-post-markdown-preview
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
force-pushed
the
feature/discussion-post-markdown-preview
branch
from
March 16, 2023 10:31
fd9740b
to
2a1e8fe
Compare
notbakaneko
force-pushed
the
feature/discussion-post-markdown-preview
branch
from
March 16, 2023 11:20
2a1e8fe
to
6297f89
Compare
notbakaneko
force-pushed
the
feature/discussion-post-markdown-preview
branch
from
April 11, 2023 07:22
d7f3743
to
6b16274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #9843
Tries to have less deadspace for the posts and input; text now wraps around the top action buttons.
Also separates various component styles instead of trying to share and contort them into the proper positions since they're really only tangentially related...
currently borrows
header-nav-v4
's style for the tabs 👀WIP while I find more missing stuff and debug more weird behaviour...