Add disband team button #11758
Open
Add disband team button #11758
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
reviewed
Dec 20, 2024
| if ($ret) { | ||
| $this->header()->delete(); | ||
| $this->logo()->delete(); | ||
| $this->members()->delete(); |
There was a problem hiding this comment.
I feel like the db stuff should be deleted together in a transaction, and the assets should be removed first so there's no dangling stuff if something somehow fails (can just try delete the team again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should contain all the things involved in deleting a team 🤔 (well, in the sense of whatever implemented at the moment which doesn't include pending team application because the model doesn't exist yet and the team chat channel)
Which currently just involves deleting the team itself and related files and member entries ┐(ﾟヮﾟ)┌
Extra things I can think of: