Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit typescript types and rename webpack define const #11756

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Dec 19, 2024

Alternative to #11726. I think those are the minimum set of explicit types config required.

Renamed the variable to reduce confusion as it's a preprocessing done through webpack and has nothing to do with node's process.env.

This also fixes typing for setTimeout and stuff without having to use window.setTimeout. I'm not updating them here though.

@notbakaneko notbakaneko merged commit 79a6ee3 into ppy:master Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants