Show custom user tags on beatmapset #11750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn description with response?
nanaya
reviewed
Dec 17, 2024
nanaya
requested changes
Dec 19, 2024
| // TODO: Add option to multi query when beatmapset requests all tags for beatmaps? | ||
| return $this->memoize( | ||
| __FUNCTION__, | ||
| fn () => cache_remember_mutexed( |
There was a problem hiding this comment.
mutexed seems not very useful when it's just db access? Like, nothing would work if the db is unhealthy.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like this?
This isn't the final display, just something to get going (There was some discussion about show counts and colour coding the tag types as well, differentiating user/mapper tags, etc), those will be separate; I don't think there's anything set up to write tags yet either? 👀
I just combined the mapper and user tags into the same tag it they're the same for now.
The Beatmap top tag cache now only caches the id and count, and the tags are moved into a local singleton cache.
The
api.beatmap.tags.indexendpoint is also removed since that doesn't seem useful when you're probably wanting the tags together with the Beatmap/Beatmapset with the mapper tags as well?I'm also splitting up the search and indexing part into a separate PR after shuffling some things around.