Add submission-relevant events to database via LIO endpoints #11741
+94
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
using parameter (something like |
nanaya
requested changes
Dec 16, 2024
app/Models/Event.php
Outdated
| $textClean = "[{$userParams['url_clean']} {$userParams['username']}] has submitted a new beatmap [{$beatmapsetParams['url_clean']} {$beatmapsetParams['title']}]"; | ||
|
|
||
| $params = [ | ||
| 'text' => "<b><a href='{$userParams['url']}'>{$userParams['username']}</a></b> has submitted a new beatmap \"<a href='{$beatmapsetParams['url']}'>{$beatmapsetParams['title']}\"</a>", |
There was a problem hiding this comment.
closing quote should be after </a>
app/Models/Event.php
Outdated
| $textClean = "[{$beatmapsetParams['url_clean']} {$beatmapsetParams['title']}] has been revived from eternal slumber by [{$userParams['url_clean']} {$userParams['username']}]"; | ||
|
|
||
| $params = [ | ||
| 'text' => "<a href='{$beatmapsetParams['url']}'>{$beatmapsetParams['title']}</a> has been revived from eternal slumber by <b><a href='{$userParams['url']}'>{$userParams['username']}</a></b>", |
app/Models/Event.php
Outdated
| $textCleanBeatmapsetUrl = $GLOBALS['cfg']['app']['url'].$beatmapsetUrl; | ||
| $textCleanUserUrl = $GLOBALS['cfg']['app']['url'].$userUrl; | ||
| $textClean = "[{$textCleanBeatmapsetUrl} {$beatmapsetTitle}] by [{$textCleanUserUrl} {$userName}] has just been {$approval}!"; | ||
| $textClean = "[{$beatmapsetParams['url_clean']} {$beatmapsetParams['title']}] by [{$userParams['url_clean']} {$userParams['username']}] has just been {$approval}!"; |
There was a problem hiding this comment.
I wonder if it's better to have same template string for both text and textClean and fill it up with sprintf accordingly, kinda similar to how it was originally done
There was a problem hiding this comment.
You mean like b2937ec?
I'd say it's a beneficial change yeah, because only thanks to it I noticed two of the events I added had quotes missing in the text_clean variant that should have been there 😅
Merged
2 tasks
|
Issues look to be addressed, so going to get this in to keep the train chugging 🚂 |
peppy
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC.
This is needed for new BSS. osu-web-10 originally would write rows to
osu_eventson new beatmap, on beatmap update, and on revive. I would normally just reimplement that in https://github.com/ppy/osu-server-beatmap-submission and call it a day, but the logic is annoying because it contains stuff like stripping tags and other html garbage that I really don't want to touch, and that web already has implemented, so I figured that I can just parasite off of the existing LIO calls that look vaguely relevant to do the job (and add another one for update I guess since that one didn't exist).In order to avoid old BSS double-writing these event rows I made this conditional on
x-api-versionheader. This is probably a war crime, but I figured I probably should not try and invent anything new. If you have better ideas then I'm all ears.For cross-reference purposes: