Replace ts-loader and terser with swc #11740
Open
+111
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to have a bit of context for this in the opening post. |
|
I don't think we're going to be simply changing our tooling "just because" (and definitely not for being the new in-thing or whatever) |
|
apparently it cut off build time.
(all in seconds) I haven't checked the output or anything else. |
|
Sorry for not including an opening post, the reason for the change is to make builds faster. The output of swc is smaller than ts.
|
|
seems mostly fine but that there's a duplicate target config may mean it'll be forgotten at one point... also the build time is just a tiny portion for github action and on dev it's only the first build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.