Fix highest rank tooltip being misaligned on mobile #11613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
requested changes
Nov 1, 2024
| <div className={`${bn}__label`}>{label}</div> | ||
| <div className={`${bn}__value`}>{value}</div> | ||
| {description != null && <div className={`${bn}__description`}>{description}</div>} | ||
| <div style={{ width: 'max-content' }}> |
There was a problem hiding this comment.
this breaks description area (like in kudosu section). just add align-items: flex-start to the value-display class instead.
There was a problem hiding this comment.
That makes the hover/click area confined to the rank (bad for - and one digits as described in OP). I've moved the description out of the new div.
There was a problem hiding this comment.
I see...? Although might as well position it at the bottom left instead (with data-tooltip-position).
Also, inlining css is generally avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this is the correct fix. Wanted to keep the hover/click area width at least the label width, so one digits are still easy to hover/click.