Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ApiDoc definitions #11433

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

notbakaneko
Copy link
Collaborator

@notbakaneko notbakaneko commented Aug 14, 2024

Fixing apidocs with wrong auto-generated examples, etc.
Moving repetitive definitions to attributes so their values can be set be params instead of repeating the whole thing every time. Using attributes because customizing the parsing for phpdoc blocks is not so great...

closes #11427

Draft while I get better ideas on handling params going to stop here for this part before the scope creeps forever

@nanaya
Copy link
Collaborator

nanaya commented Sep 11, 2024

I wonder if all the default limit should be unified to the const

@notbakaneko notbakaneko force-pushed the docs/missing-param-types branch 2 times, most recently from b5d7347 to f64d3fe Compare September 18, 2024 09:13
@notbakaneko notbakaneko marked this pull request as ready for review September 18, 2024 09:14
@notbakaneko notbakaneko marked this pull request as draft October 7, 2024 11:50
@notbakaneko
Copy link
Collaborator Author

redraft again while I check if there was something else to be updated after the other PR was merged 🤔

@notbakaneko notbakaneko force-pushed the docs/missing-param-types branch from f64d3fe to 579027f Compare November 28, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Next up
Development

Successfully merging this pull request may close these issues.

Some errors in osu!web documentation
2 participants