Show legacy forum icons on topic listing, posts, and post search #11277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cl8n
commented
Jun 17, 2024
Comment on lines
+24
to
+31
| $table->mediumIncrements('icons_id'); | ||
| $table->string('icons_url')->default(''); | ||
| $table->tinyInteger('icons_width')->default(0); | ||
| $table->tinyInteger('icons_height')->default(0); | ||
| $table->unsignedMediumInteger('icons_order')->default(0); | ||
| $table->boolean('display_on_posting')->default(true); | ||
|
|
||
| $table->index(['display_on_posting'], 'display_on_posting'); |
There was a problem hiding this comment.
could use a double-check for accuracy bc I just copied thsi from phpbb3.0
nanaya
requested changes
Jun 21, 2024
| use App\Traits\Memoizes; | ||
| use Illuminate\Database\Eloquent\Collection; | ||
|
|
||
| class ForumLegacyIcons |
There was a problem hiding this comment.
It doesn't seem it's used frequently enough to warrant this (and all the usage seems involve querying the post/topic)
| <img | ||
| alt="" | ||
| class="forum-legacy-icon" | ||
| src="{{ osu_url('forum_legacy_icons') }}/{{ $icon->icons_url }}" |
There was a problem hiding this comment.
the url generation should be the icon's method
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| .forum-legacy-icon { | ||
| margin: 0 5px; |
There was a problem hiding this comment.
I think this can use gap on __icons instead
| @@ -14,6 +14,11 @@ | |||
| > | |||
| <img class="search-forum-post__avatar-image" src="{{ $user->user_avatar }}"> | |||
| </a> | |||
|
|
|||
| @if ($post->legacyIcon() !== null) | |||
There was a problem hiding this comment.
I don't think this is a good place to put the icon. It just looks wrong
There was a problem hiding this comment.
Icons should go before or after the title, or in the information lines at the bottom, imo. It should definitely not be shifting the layout of entire blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2814
it's pretty ugly with most icons but I hope that can be forgiven since it's just a historical thing.