-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API endpoints for creating/editing beatmap discussion posts #11113
base: master
Are you sure you want to change the base?
Conversation
I'm against supporting this, so it should be limited for now to not allow that. This is in line with other restrictions we currently have like third party apps should not be able to post on forums as a user. Maybe client-auth only for lazer to start with. |
In that case, would adding it to the the scopes that require client delegation (like |
there is no such restriction 🙈 maybe you're thinking of chat messages, which do have some additional requirements what problems do you see with adding more write scopes like this? if it's going to be a blocker for third party, we should at least be tracking what needs to be done somewhere. maybe #10589 is related |
Closes #10199
Adds the ability to create new beatmap discussions, reply to existing discussions, and updating discussion posts, via the API. The whole thing is based on the forum API for how OAuth scopes are set up (
forum.write
scope).Use cases
List of all changes:
BeatmapDiscussionPostsController.store
andBeatmapDiscussionPostsController.update
beatmap_discussion.write
OAuth scopeBeatmapDiscussionPostsController.store
andBeatmapDiscussionPostsController.update
RouteScopesTest
beatmap_discussion.write
OAuth scope