Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API endpoints for creating/editing beatmap discussion posts #11113

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

minetoblend
Copy link

@minetoblend minetoblend commented Mar 24, 2024

Closes #10199

Adds the ability to create new beatmap discussions, reply to existing discussions, and updating discussion posts, via the API. The whole thing is based on the forum API for how OAuth scopes are set up (forum.write scope).

Use cases

  • Bots that automatically detect unrankables and create posts about it
  • Ability to write mods in third party mapping tools & editors
  • Would help pave the way for modding in the lazer editor

List of all changes:

  • Added API endpoints for BeatmapDiscussionPostsController.store and BeatmapDiscussionPostsController.update
  • Added a beatmap_discussion.write OAuth scope
  • Added API Documentation for BeatmapDiscussionPostsController.store and BeatmapDiscussionPostsController.update
  • Made adjustments to expected endpoints in RouteScopesTest
  • Added English & German translations for beatmap_discussion.write OAuth scope

@peppy
Copy link
Member

peppy commented Mar 25, 2024

Ability to write mods in third party mapping tools & editors

I'm against supporting this, so it should be limited for now to not allow that. This is in line with other restrictions we currently have like third party apps should not be able to post on forums as a user.

Maybe client-auth only for lazer to start with.

@minetoblend
Copy link
Author

In that case, would adding it to the the scopes that require client delegation (like chat.write) work?
That way it can still be used by bot accounts & lazer, while not being able to post as regular users.

@cl8n
Copy link
Member

cl8n commented Mar 25, 2024

This is in line with other restrictions we currently have like third party apps should not be able to post on forums as a user.

there is no such restriction 🙈 maybe you're thinking of chat messages, which do have some additional requirements

what problems do you see with adding more write scopes like this? if it's going to be a blocker for third party, we should at least be tracking what needs to be done somewhere. maybe #10589 is related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add create/edit/delete beatmap discussion post API endpoints
4 participants