Update mania simulate command to accept hit result counts #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
approved these changes
Dec 11, 2023
MrHeliX
pushed a commit
to MrHeliX/osu-tools
that referenced
this pull request
Jun 5, 2024
Update mania simulate command to accept hit result counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while investigating ppy/osu#25719. I wanted to confirm what the reporter was saying about the PP numbers reported being for nomod rather than daycore, and proceeded to find that mania simulate would return entirely different numbers.
Score has not been used for performance calculation since ppy/osu#18749, so the current code's assertion that "only total number of hits is considered currently" is no longer correct.
The "hit statistics from accuracy" approximation thing is very loose and not intended to really be that useful, but it should technically yield the expected accuracy value (there are multiple possible solutions, this just finds one of them). I don't think that function is particularly useful or accurate in any ruleset anyhow.