Rename more machines (small vs large) and add runtime checks #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
commented
Oct 9, 2024
| @@ -32,36 +31,3 @@ machine ByteBinary with | |||
| } | |||
| }; | |||
| } | |||
|
|
|||
| machine Binary(byte_binary: ByteBinary) with | |||
There was a problem hiding this comment.
This moved to large_field::binary
leonardoalt
commented
Oct 9, 2024
| regular_test(f, &[]); | ||
| fn memory_large_test_parallel_accesses() { | ||
| let f = "std/memory_large_test_parallel_accesses.asm"; | ||
| regular_test_without_babybear(f, &[]); |
There was a problem hiding this comment.
These fail the field size check now. Not sure how they passed before with bb.
leonardoalt
commented
Oct 9, 2024
| fn shift_small_test() { | ||
| let f = "std/shift_small_test.asm"; | ||
| test_plonky3_with_backend_variant::<BabyBearField>(f, vec![], BackendVariant::Composite); | ||
| } |
There was a problem hiding this comment.
This test existed but wasn't used.
leonardoalt
commented
Oct 9, 2024
| use std::field::modulus; | ||
| use std::check::assert; | ||
| use std::machines::binary::ByteBinary; | ||
|
|
There was a problem hiding this comment.
Copied from std::machines::binary::Binary
leonardoalt
commented
Oct 9, 2024
| // Allow this machine to be connected via a permutation | ||
| call_selectors: sel, | ||
| { | ||
| assert(modulus() > 2**32, || "Binary requires a field that fits any 32-Bit value."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.