Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed con to conn for uniform naming (Issue#759) #863

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

raikan-san
Copy link

@raikan-san raikan-san commented Sep 6, 2023

Describe your changes

Renamed con -> conn for uniformity

Issue number

Closes #759

Checklist before requesting a review

  • Performed a self-review of my code
  • Formatted my code with pkgmt format

📚 Documentation preview 📚: https://jupysql--863.org.readthedocs.build/en/863/

@raikan-san raikan-san marked this pull request as ready for review September 6, 2023 04:45
CHANGELOG.md Outdated Show resolved Hide resolved
@edublancas edublancas added the no-changelog This PR doesn't require a changelog entry label Sep 6, 2023
@edublancas
Copy link

@nooodle-soup also, please add a descriptive name to the PR

@raikan-san raikan-san changed the title Issue#759 Renamed con to conn for uniform naming (Issue#759) Sep 6, 2023
@raikan-san
Copy link
Author

Renamed and removed changelog changes

@edublancas edublancas merged commit 73e62b0 into ploomber:master Sep 6, 2023
23 checks passed
@raikan-san raikan-san deleted the issue#759 branch September 8, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog This PR doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename con -> conn
2 participants