Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duckdbfix #690

Closed
wants to merge 11 commits into from
Closed

Duckdbfix #690

wants to merge 11 commits into from

Conversation

edublancas
Copy link

@edublancas edublancas commented Jun 29, 2023

Putting my notes here so I don't lose them:

  • calling run_cell should raise an exception if it fails (but this means we'll have to update a lot of tests)
  • community link logic fails when raising an exception with no args (e.g., raise ValueError)
  • we shouldn't require ; at the end of each command (sqlparse fails)
  • execution in the magic should stop in the first command with errors, and maybe rollback? i think currently it commits each one by default
  • I'm getting too many open files error when running test_magic.py

Describe your changes

Issue number

Closes #X

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--690.org.readthedocs.build/en/690/

@edublancas edublancas closed this Jun 29, 2023
@edublancas edublancas deleted the duckdbfix branch June 29, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant