Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTE generation when the snippets have trailing semicolons #544

Merged
merged 1 commit into from
May 30, 2023

Conversation

edublancas
Copy link

@edublancas edublancas commented May 30, 2023

Describe your changes

Issue number

Closes #319

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--544.org.readthedocs.build/en/544/

@edublancas edublancas marked this pull request as ready for review May 30, 2023 04:39
@neelasha23
Copy link

Added a couple of comments.
For the CTE deprecation PR there's test file named test_compose.py. Should I rename to test_magic_cte.py as per this PR?

@edublancas
Copy link
Author

Added a couple of comments.
For the CTE deprecation PR there's test file named test_compose.py. Should I rename to test_magic_cte.py as per this PR?

yes, please rename it

@edublancas edublancas merged commit 1b2713e into master May 30, 2023
@edublancas edublancas deleted the ctes branch May 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleaning trailing ; when building CTEs
2 participants