pin mkdocs_autorefs to compatible version #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes an error in mkdocs_autorefs/plugin.py, line 77: TypeError: type 'BasePlugin' is not subscriptable
stephenhillier
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an error in mkdocs_autorefs/plugin.py, line 77:
TypeError: type 'BasePlugin' is not subscriptable
Bigger picture, mkdocs added type annotations to it's plugin system (in 1.4.0?) and the downstream plugin began using the new API after 1.0.1 or so
Related Issue(s):
Fixes nox 'docs' session, example breakage here: https://github.com/planetlabs/planet-client-python/actions/runs/10857195949/job/30210383772?pr=1055
PR Checklist:
(Optional) @mentions for Notifications:
@stephenhillier @tbarsballe