-
Notifications
You must be signed in to change notification settings - Fork 92
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c7ed86c
commit a9ff294
Showing
1 changed file
with
6 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,8 @@ | ||
- TODO: Deprecated the legacy secret file. This will require a user migration. (todo : provide instructions for bootstrapping the new file) | ||
Maybe I can jigger from_file to still do the old thing, and just steer new logins | ||
- TODO: deprecate the legacy auth command | ||
- TODO: migrate planet.Auth to planet_auth.Auth as much as possible | ||
- TODO: Don't forget env var behaviors | ||
- TODO: good handing for PL_CLIENT_ID and PL_CLIENT_SECRET | ||
- Replaced most user auth code with the planet auth library. This brings with it OAuth for user interactive and M2M flows. | ||
- Deprecated the old auth command. New auth command is implemented with the separate auth library | ||
- TODO: link to lib | ||
- planet auth init -> planet auth oauth login (or, planet --auth-profile legacy auth legacy login) | ||
- planet auth value -> planet plauth oauth print-access-token (or planet --auth-profile legacy auth legacy print-api-key) | ||
- The legacy secret file has largely been deprecated. This will require a user migration. | ||
|
||
# TODO: The old code would have a in-memory authenticator here. Verify behavior. | ||
# TODO: we do not have a good way to initialize M2M OAuth tokens from the env (I think? Maybe we do.) This really belongs to plauth | ||
# TODO: we need to allocate a client ID for the `planet` CLI. We are presently leaning on plauth's client ID. (maybe this is OK) | ||
# TODO: finalize message in translate_exceptions steering users to how to initialize auth. |