-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make where we work with BOSH Release tarballs explicit #405
Make where we work with BOSH Release tarballs explicit #405
Conversation
they were already an alias, this removes that indirection
this makes it clearer what is being worked with
add Tarball and make it clear we are working with BOSH releases
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
Here is some "prior art". PR #405 is bigger because it merges and renames; the prior art commit does not merge the types it just renames cargo type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent refactor. LGTM.
TL;DR
component.Spec
andcargo.ComponentSpec
->cargo.BOSHReleaseTarballSpecification
component.Lock
andcargo.ComponentLock
->cargo.BOSHReleaseTarballLock
cargo.ReleaseSourceTypeBOSHIO
->cargo.BOSHReleaseTarballSourceTypeBOSHIO
cargo.ReleaseSourceTypeS3
->cargo.BOSHReleaseTarballSourceTypeS3
cargo.ReleaseSourceTypeGithub
->cargo.BOSHReleaseTarballSourceTypeGithub
cargo.ReleaseSourceTypeArtifactory
->cargo.BOSHReleaseTarballSourceTypeArtifactory
Discussion
This refactor is intended to make it easier to think about and code around the BOSH releases tarballs we package.
component.Lock
andcargo.ComponentLock
. They have literally been the same thing for a while; this commit removes the indirection.component.Local
andcomponent.Exported
no longer embed thecargo.ComponentLock
but have it as a non-embedded field. This makes refactors easier and makes it clear that those types should not inherit methods from the Lock. For the most part, this change is reversible in a non-breaking way.