Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make controller's os.RemoveAll single-threaded #5217

Merged
merged 2 commits into from
Sep 24, 2024

Close the workingDirRemovalCh

efa4e6d
Select commit
Loading
Failed to load commit list.
Merged

Make controller's os.RemoveAll single-threaded #5217

Close the workingDirRemovalCh
efa4e6d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 19, 2024 in 1s

0.00% of diff hit (target 22.83%)

View this Pull Request on Codecov

0.00% of diff hit (target 22.83%)

Annotations

Check warning on line 193 in pkg/app/piped/controller/controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/controller/controller.go#L192-L193

Added lines #L192 - L193 were not covered by tests

Check warning on line 233 in pkg/app/piped/controller/controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/controller/controller.go#L229-L233

Added lines #L229 - L233 were not covered by tests

Check warning on line 268 in pkg/app/piped/controller/controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/controller/controller.go#L264-L268

Added lines #L264 - L268 were not covered by tests

Check warning on line 274 in pkg/app/piped/controller/controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/controller/controller.go#L273-L274

Added lines #L273 - L274 were not covered by tests

Check warning on line 511 in pkg/app/piped/controller/controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/controller/controller.go#L510-L511

Added lines #L510 - L511 were not covered by tests

Check warning on line 653 in pkg/app/piped/controller/controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/controller/controller.go#L652-L653

Added lines #L652 - L653 were not covered by tests