-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the persistence of the Grafana Tempo #5208
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5208 +/- ##
==========================================
- Coverage 22.83% 22.81% -0.03%
==========================================
Files 420 420
Lines 45302 45302
==========================================
- Hits 10344 10334 -10
- Misses 34163 34172 +9
- Partials 795 796 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This reverts commit 41ae6d1. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
This reverts commit 41ae6d1. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
What this PR does / why we need it:
Without this PR, the traces are lost when the tempo pod is evicted.
The StatefulSet manages the tempo's pod, so usually it does not occur, but it occurs with the times such as when the configmap is changed.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: Yes only if users use the control plane version v0.49.0-rc0
How are users affected by this change:
When users using control plane helm chart with monitoring.enabled as true, they cannot upgrade the control plane without manual operation.
Is this breaking change: Yes
How to migrate (if breaking change):
Delete the Grafana Tempo's StatefulSet before applying the Helm Chart.