Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Terraform plan result handling #5177

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

golemiso
Copy link
Contributor

@golemiso golemiso commented Sep 3, 2024

What this PR does / why we need it:

  • Make it possible to handle terraform plan results when:
    • adding new outputs
    • removing resources from state using removed block
    • refactoring *.tf files using moved block

without these modifications, pipecd returns no changes or unable to parse plan output.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great work!
I checked the piped-side behavior, and it worked successfully.
It's difficult to check the actions-plan-preview side behavior without merging this PR, so we should check it after merging it.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Note: We also have to release tool/actions-plan-preview in order to test this. Let's release a rc for testing the GitHub actions behaviors.

@Warashi Warashi merged commit 25e9a71 into pipe-cd:master Sep 5, 2024
21 checks passed
@golemiso golemiso deleted the improve-terraform-result-handling branch September 5, 2024 02:51
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants