Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #4448 #4486 #4522 #4527

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tag: v0.44.0
tag: v0.44.2

releaseNoteGenerator:
showCommitter: false
Expand Down
13 changes: 13 additions & 0 deletions docs/content/en/blog/releases/v0.44.1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
title: "Release v0.44.1"
linkTitle: "Release v0.44.1"
date: 2023-06-26
description: >
Release v0.44.1
---

## Changes since v0.44.0

### Bug Fixes

* Fix Terraform drift render logic that causes runtime error ([#4444](https://github.com/pipe-cd/pipecd/pull/4444))
25 changes: 25 additions & 0 deletions docs/content/en/blog/releases/v0.44.2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
title: "Release v0.44.2"
linkTitle: "Release v0.44.2"
date: 2023-07-12
description: >
Release v0.44.2
---

## Changes since v0.44.1
### New Features
* Enable to install Helm and Kustomize if both versions are specified ([#4463](https://github.com/pipe-cd/pipecd/pull/4463))
* Support AWS LoadBalancer with multi listeners ([#4462](https://github.com/pipe-cd/pipecd/pull/4462))

### Notable Changes
* Update logs message for ECS routing stage executor ([#4466](https://github.com/pipe-cd/pipecd/pull/4466))
* Output usage only when flag parsing fails [#4381](https://github.com/pipe-cd/pipecd/pull/4381) ([#4464](https://github.com/pipe-cd/pipecd/pull/4464))
* Update quickstart to support arm hardware(ex: M1) ([#4457](https://github.com/pipe-cd/pipecd/pull/4457))

### Bug Fixes
* Skip update AppState when no log updates ([#4482](https://github.com/pipe-cd/pipecd/pull/4482))
* Update deprecated apiVersion since GKE removed ([#4469](https://github.com/pipe-cd/pipecd/pull/4469))
* Fix ECS rollback stage does not remove canary created tasks ([#4465](https://github.com/pipe-cd/pipecd/pull/4465))

### Internal Changes
* Update web deps ([#4451](https://github.com/pipe-cd/pipecd/pull/4451))
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ Must be one of the following structs:
| Field | Type | Description | Required |
|-|-|-|-|
| vars | []string | List of variables that will be set directly on terraform commands with `-var` flag. The variable must be formatted by `key=value`. | No |
| driftDetectionEnabled | bool | Enable drift detection. This is a temporary option and will be possibly removed in the future release. Default is `true` | No |

### PlatformProviderCloudRunConfig

Expand Down
3 changes: 3 additions & 0 deletions pkg/app/piped/driftdetector/detector.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ func NewDetector(
))

case model.PlatformProviderTerraform:
if !*cp.TerraformConfig.DriftDetectionEnabled {
continue
}
sg, ok := stateGetter.TerraformGetter(cp.Name)
if !ok {
return nil, fmt.Errorf(format, cp.Name)
Expand Down
3 changes: 3 additions & 0 deletions pkg/config/piped.go
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,9 @@ type PlatformProviderTerraformConfig struct {
// 'image_id_list=["ami-abc123","ami-def456"]'
// 'image_id_map={"us-east-1":"ami-abc123","us-east-2":"ami-def456"}'
Vars []string `json:"vars,omitempty"`
// Enable drift detection.
// TODO: This is a temporary option because Terraform drift detection is buggy and has performace issues. This will be possibly removed in the future release.
DriftDetectionEnabled *bool `json:"driftDetectionEnabled" default:"true"`
}

type PlatformProviderCloudRunConfig struct {
Expand Down
1 change: 1 addition & 0 deletions pkg/config/piped_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ func TestPipedConfig(t *testing.T) {
"project=gcp-project",
"region=us-centra1",
},
DriftDetectionEnabled: newBoolPointer(false),
},
},
{
Expand Down
1 change: 1 addition & 0 deletions pkg/config/testdata/piped/piped-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ spec:
vars:
- "project=gcp-project"
- "region=us-centra1"
driftDetectionEnabled: false

- name: cloudrun
type: CLOUDRUN
Expand Down