Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS LoadBalancer with multi listeners #4462

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jul 3, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2065

Does this PR introduce a user-facing change?:

  • Is this breaking change:
  • How to migrate (if breaking change):
  • How are users affected by this change:

Signed-off-by: khanhtc1202 <[email protected]>
@khanhtc1202 khanhtc1202 marked this pull request as ready for review July 4, 2023 10:38
Copy link
Member

@kentakozuka kentakozuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉
Left some nits

@@ -277,29 +277,29 @@ func (c *client) ServiceExists(ctx context.Context, clusterName string, serviceN
return false, nil
}

func (c *client) GetListener(ctx context.Context, targetGroup types.LoadBalancer) (string, error) {
func (c *client) GetListenersArn(ctx context.Context, targetGroup types.LoadBalancer) ([]string, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better naming?

Suggested change
func (c *client) GetListenersArn(ctx context.Context, targetGroup types.LoadBalancer) ([]string, error) {
func (c *client) GetListenerArns(ctx context.Context, targetGroup types.LoadBalancer) ([]string, error) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, I like the current one but will change it as I accepted you point as well 😄

pkg/app/piped/platformprovider/ecs/client.go Outdated Show resolved Hide resolved
Signed-off-by: khanhtc1202 <[email protected]>
Copy link
Member

@kentakozuka kentakozuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always 😄

@khanhtc1202 khanhtc1202 merged commit 36e2948 into master Jul 4, 2023
13 checks passed
@khanhtc1202 khanhtc1202 deleted the multi-listeners branch July 4, 2023 11:33
kentakozuka pushed a commit that referenced this pull request Jul 12, 2023
* Support AWS LoadBalancer with multi listeners

Signed-off-by: khanhtc1202 <[email protected]>

* Fix go array index

Signed-off-by: khanhtc1202 <[email protected]>

* Rename symbol

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
kentakozuka pushed a commit that referenced this pull request Jul 12, 2023
* Support AWS LoadBalancer with multi listeners

Signed-off-by: khanhtc1202 <[email protected]>

* Fix go array index

Signed-off-by: khanhtc1202 <[email protected]>

* Rename symbol

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
kentakozuka added a commit that referenced this pull request Jul 12, 2023
)

* Update web deps (#4451)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>

* Update quickstart to support arm hardware(ex: M1) (#4457)

* Add: arch selection for mysql image
Update chart values and templates for mysql deployment

Signed-off-by: gitbluf <[email protected]>

* Update: MySql image selector function to be more descriptive

Signed-off-by: gitbluf <[email protected]>

* Remove: mysql image set on piped installation

Signed-off-by: gitbluf <[email protected]>

* Update method name

Signed-off-by: gitbluf <[email protected]>

---------

Signed-off-by: gitbluf <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>

* Support AWS LoadBalancer with multi listeners (#4462)

* Support AWS LoadBalancer with multi listeners

Signed-off-by: khanhtc1202 <[email protected]>

* Fix go array index

Signed-off-by: khanhtc1202 <[email protected]>

* Rename symbol

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>

* Specify Version For Templating Tools (#4463)

* specify version for templating tools

Signed-off-by: Viet Anh Pham Nhu <[email protected]>

* Handle Error Both Install Helm And Kustomize

Signed-off-by: Viet Anh Pham Nhu <[email protected]>

---------

Signed-off-by: Viet Anh Pham Nhu <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>

* Output usage only when flag parsing fails #4381 (#4464)

Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>

* Fix ECS rollback stage does not remove canary created tasks (#4465)

* Fix cannot remove canary created task

Signed-off-by: ductnn <[email protected]>

* Fix reuse clean function

Signed-off-by: ductnn <[email protected]>

* Update logs message for ECS routing stage rollback

Signed-off-by: ductnn <[email protected]>

---------

Signed-off-by: ductnn <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>

* Update logs message for ECS routing stage executor (#4466)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>

* fix: update deprecated apiVersion since gke removed (#4469)

GoogleCloudPlatform/gke-managed-certs#58

Signed-off-by: hungran <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>

* Skip update AppState when no log updates (#4482)

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: gitbluf <[email protected]>
Signed-off-by: Viet Anh Pham Nhu <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: ductnn <[email protected]>
Signed-off-by: hungran <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: Marko Petrovic <[email protected]>
Co-authored-by: Viet Anh Pham Nhu <[email protected]>
Co-authored-by: Yoshiki Fujikane <[email protected]>
Co-authored-by: Duc Tran <[email protected]>
Co-authored-by: Henry Vu <[email protected]>
Co-authored-by: Kurochan <[email protected]>
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi listeners pattern.
2 participants