optionally display STOPPING and STOPPED hosts #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the environment overview page only showed hosts in the deploy status that were not STOPPING or STOPPED. The only way to look at them is to look in "Total" hosts. First of all, it doesn't make sense to me to to have an agent state that shows up in the TOTAL but isn't available in the board. This adds an extra configuration parameter to display STOPPING and STOPPED hosts. It is disabled by default, in case you have some reason you do not display those states. Related: pinterest#354
|
+@sbaogang for comment on STOPPING and STOPPED. |
|
I am all for it - STOPPING/STOPPED was added as a new feature to gracefully shutdown apps sometimes ago, apparently the UI part was not updated. |
|
Perhaps we should default it to enabled, then? Is there a reason to hide this? |
|
I think it should be enabled by default, Nathan, can you make it be enabled? Also, I'd like to have your agreement on distributing the code in Apache 2.0 license for me to merge it. You can reply your agreement just here. |
|
I agree to have my code released under the Apache 2.0 license. |
I missed this earlier in d5e5efa - changed it in manage.py but not in settings.py.
lilida
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the environment overview page only showed hosts in the deploy
status that were not STOPPING or STOPPED. The only way to look at them is to
look in "Total" hosts.
First of all, it doesn't make sense to me to to have an agent state that shows
up in the TOTAL but isn't available in the board.
This adds an extra configuration parameter to display STOPPING and STOPPED
hosts. It is disabled by default, in case you have some reason you do not
display those states.
Related: #354
Current behavior:
Notice the TOTAL for the Previous(a2f66f1) build is
1, even though none of the state columns actually display 1 host!With
os.environ.setdefault("DISPLAY_STOPPING_HOSTS", "true")inmanage.py, we can see even the stopped hosts: