Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load stats in index usage reporter for point get requests to accelerate it #58477

Open
YangKeao opened this issue Dec 23, 2024 · 1 comment · May be fixed by #58478
Open

Don't load stats in index usage reporter for point get requests to accelerate it #58477

YangKeao opened this issue Dec 23, 2024 · 1 comment · May be fixed by #58478
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

The point get requests don't have stats most of the time. Loading the stats may consume a lot of resource. We can always use the smallest bucket (when the result is greater than 0) to accelerate the process.
@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label Dec 23, 2024
@YangKeao YangKeao linked a pull request Dec 23, 2024 that will close this issue
Draft
13 tasks
@YangKeao
Copy link
Member Author

TODO: add benchmark result here to show whether it's valuable enough to trade off the accuracy to get performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor, indexusage: don't load stats for point get index usage reporter YangKeao/tidb
1 participant
@YangKeao