Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking internet connectivity before calling register #497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghominejad
Copy link

In the most of times calling GCMRegistrar.register function with no internet access causes generating new registration id in the next runs (one or two) .
We call the GCMRegistrar.register only if the network is available.

In the most of times calling `GCMRegistrar.register` function with no internet access causes generating new registration id in the next runs (one or two) .
We call the `GCMRegistrar.register` if the network is available.
@cyriljoui
Copy link

👍

@ghominejad
Copy link
Author

I hope this is useful, Could you please give me some feedback if you see any registration problems as your experiences?

@cyriljoui
Copy link

Of course! I will do for sure :)
Moreover I will check if we really need to call GCMRegistrar.register each start...

@ghominejad
Copy link
Author

Thank you :)
Yes, i also think this is not the best solution, we shouldn't call register function when application starts. if we really don't need to call it, then your solution is best. at least we can call the register function occasionally (once per day).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants