Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hexagonal get tile corners #6826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/tilemaps/components/HexagonalGetTileCorners.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,18 @@ var HexagonalGetTileCorners = function (tileX, tileY, camera, layer)
}

// Sets the center of the tile into tempVec
var tempVec = new Vector2();
var center = HexagonalTileToWorldXY(tileX, tileY, tempVec, camera, layer);

var corners = [];

// Hard-coded orientation values for Pointy-Top Hexagons only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove a useful comment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is contradictory, the value is not only used for Pointy-Top Hexagons, but an aid to calculating the long diagonals. Better comment: We assume a pointy-top orientation.

// We assume a pointy-top orientation (staggerAxis == 'y')
var b0 = 0.5773502691896257; // Math.sqrt(3) / 3

var rotation = 0;
var hexWidth;
var hexHeight;

if (layer.staggerAxis === 'y')
if (layer.staggerAxis == 'y')
{
hexWidth = b0 * tileWidth;
hexHeight = tileHeight / 2;
Expand All @@ -54,11 +55,13 @@ var HexagonalGetTileCorners = function (tileX, tileY, camera, layer)
{
hexWidth = tileWidth / 2;
hexHeight = b0 * tileHeight;
rotation = 30 * Math.PI /180;
}

for (var i = 0; i < 6; i++)
{
var angle = 2 * Math.PI * (0.5 - i) / 6;
angle += rotation;

corners.push(new Vector2(center.x + (hexWidth * Math.cos(angle)), center.y + (hexHeight * Math.sin(angle))));
}
Expand Down