Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add requirement on Nonce payload to contain an actual random value #23

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

millenc
Copy link
Contributor

@millenc millenc commented Apr 18, 2024

This PR addresses issues: #6 and #22 (duplicated).

Changes introduced by this PR:

  • The non-normative Nonce payload example now includes a jti claim and a disclaimer stating that it MUST always contain a random unique value
  • RFC4086 has been added to the normative references section
  • Some minor fixes on keyword usage

@peppelinux
Copy link
Owner

I also would suggest (I can do it later on anyway) to change the text 1. **Generation**: Nonces are generated by the server, while jti is generated by the Client. in the section nonce vs. jti, since this seems quite false

this is not related to your PR but to the harmonization we want with your PR

@millenc
Copy link
Contributor Author

millenc commented Apr 18, 2024

I also would suggest (I can do it later on anyway) to change the text 1. **Generation**: Nonces are generated by the server, while jti is generated by the Client. in the section nonce vs. jti, since this seems quite false

this is not related to your PR but to the harmonization we want with your PR

Agreed. It would be more accurate to state that the jti claim is generated by the token issuer, whomever that may be (typically the server but not always).

Co-authored-by: Orie Steele <[email protected]>
@peppelinux peppelinux merged commit 2a9cf90 into peppelinux:main Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniqueness of nonces of non-normative examples payload must include a random value
3 participants