Add cmd/gotoml-test-encoder #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there was already an encoder I figured adding an encoder makes sense. Also had to fix it for local dates. % toml-test -encoder ./gotoml-test-encoder toml-test v2023-10-13 [./gotoml-test-encoder]: using embedded tests encoder tests: 162 passed, 0 failed
|
I copied all the extra tests from testdata/fuzz/FuzzUnmarshal to toml-test by the way: Updating toml-test fails though, since it will also include the TOML 1.1 tests; you'll need to either use the |
|
Thank you for taking care of this! I've created a follow-up issue to update toml-test properly. |
Closed
jooola
referenced
this pull request
in hetznercloud/cli
Dec 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pelletier/go-toml/v2](https://togithub.com/pelletier/go-toml) | require | patch | `v2.1.0` -> `v2.1.1` | --- ### Release Notes <details> <summary>pelletier/go-toml (github.com/pelletier/go-toml/v2)</summary> ### [`v2.1.1`](https://togithub.com/pelletier/go-toml/releases/tag/v2.1.1) [Compare Source](https://togithub.com/pelletier/go-toml/compare/v2.1.0...v2.1.1) <!-- Release notes generated using configuration in .github/release.yml at v2.1.1 --> ##### What's Changed ##### Fixed bugs - Fix unmarshaling of nested non-exported struct by [@​pelletier](https://togithub.com/pelletier) in [https://github.com/pelletier/go-toml/pull/917](https://togithub.com/pelletier/go-toml/pull/917) ##### New Contributors - [@​arp242](https://togithub.com/arp242) made their first contribution in [https://github.com/pelletier/go-toml/pull/907](https://togithub.com/pelletier/go-toml/pull/907) - [@​mpldr](https://togithub.com/mpldr) made their first contribution in [https://github.com/pelletier/go-toml/pull/911](https://togithub.com/pelletier/go-toml/pull/911) **Full Changelog**: pelletier/go-toml@v2.1.0...v2.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there was already an encoder I figured adding an encoder makes sense. Also had to fix it for local dates.